----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58724/#review173106 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java Line 291 (original), 303 (patched) <https://reviews.apache.org/r/58724/#comment246180> add a case for 'TAG_UPDATE' repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java Lines 465 (patched) <https://reviews.apache.org/r/58724/#comment246178> "throw" missing - Madhan Neethiraj On April 26, 2017, 9:28 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58724/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 9:28 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1751 > https://issues.apache.org/jira/browse/ATLAS-1751 > > > Repository: atlas > > > Description > ------- > > Current REST implementation for classification supports only create and > delete classification associated with entities. This JIRA addresses update to > multiple classification attributes associated with entities. > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/EntityAuditEvent.java e5415314 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 7b1f2ad7 > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java > 82a1100c > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java > 9d0f8029 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > c256ae20 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java > f3d9ca7c > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 27f6928a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 9d11aa5d > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > c6d7e9d1 > > server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java > 346c8a26 > > webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java > 565eea75 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 362fb67e > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > 3161a0da > > > Diff: https://reviews.apache.org/r/58724/diff/2/ > > > Testing > ------- > > 1. mvn clean install with known failures > 2. Added unit tests. > 3. Validated that kafka topic receives notification message on classification > update. > > > Thanks, > > Sarath Subramanian > >
