----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/351/#review490 -----------------------------------------------------------
share/schemas/org/apache/avro/ipc/trace/avroTrace.avdl <http://review.hbase.org/r/351/#comment2005> Right not the Transceiver does not expose port information to the Requestor/Responder so this data is hidden. All Transceivers I can imaging will operate over TCP/UDP, so perhaps it makes sense to include a getPort int the Transceiver superclass and then also include port information in the RPCContext that is passed to the plugin? - Patrick On 2010-07-21 13:02:51, Philip Zeyliger wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/351/ > ----------------------------------------------------------- > > (Updated 2010-07-21 13:02:51) > > > Review request for Avro. > > > Summary > ------- > > AVRO-595 > > > Diffs > ----- > > lang/java/ivy.xml a781557 > lang/java/src/java/org/apache/avro/ipc/trace/InMemorySpanStorage.java > PRE-CREATION > lang/java/src/java/org/apache/avro/ipc/trace/SpanStorage.java PRE-CREATION > lang/java/src/java/org/apache/avro/ipc/trace/TracePlugin.java PRE-CREATION > lang/java/src/test/java/org/apache/avro/ipc/trace/TestBasicTracing.java > PRE-CREATION > share/schemas/org/apache/avro/ipc/trace/avroTrace.avdl PRE-CREATION > share/schemas/org/apache/avro/ipc/trace/avroTrace.avpr PRE-CREATION > > Diff: http://review.hbase.org/r/351/diff > > > Testing > ------- > > > Thanks, > > Philip > >
