> On 2010-07-21 14:38:28, Philip Zeyliger wrote: > > lang/java/src/java/org/apache/avro/ipc/trace/TracePlugin.java, lines 176-177 > > <http://review.hbase.org/r/351/diff/1/?file=2993#file2993line176> > > > > What's the 100 doing here?
GenericData.Array requires a default capacity. I will probably lower it to 10, but it needs to be specified in constructor. > On 2010-07-21 14:38:28, Philip Zeyliger wrote: > > share/schemas/org/apache/avro/ipc/trace/avroTrace.avpr, line 2 > > <http://review.hbase.org/r/351/diff/1/?file=2996#file2996line2> > > > > Is this generated? Could this be generated by the build instead of > > checked in? Avro IDL is not implemented in other languages, so building this from the avdl file would introduce a dependency on the Java code for building the projects - is that okay? - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/351/#review443 ----------------------------------------------------------- On 2010-07-21 13:02:51, Philip Zeyliger wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/351/ > ----------------------------------------------------------- > > (Updated 2010-07-21 13:02:51) > > > Review request for Avro. > > > Summary > ------- > > AVRO-595 > > > Diffs > ----- > > lang/java/ivy.xml a781557 > lang/java/src/java/org/apache/avro/ipc/trace/InMemorySpanStorage.java > PRE-CREATION > lang/java/src/java/org/apache/avro/ipc/trace/SpanStorage.java PRE-CREATION > lang/java/src/java/org/apache/avro/ipc/trace/TracePlugin.java PRE-CREATION > lang/java/src/test/java/org/apache/avro/ipc/trace/TestBasicTracing.java > PRE-CREATION > share/schemas/org/apache/avro/ipc/trace/avroTrace.avdl PRE-CREATION > share/schemas/org/apache/avro/ipc/trace/avroTrace.avpr PRE-CREATION > > Diff: http://review.hbase.org/r/351/diff > > > Testing > ------- > > > Thanks, > > Philip > >
