[ 
https://issues.apache.org/jira/browse/AVRO-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764697#comment-13764697
 ] 

Doug Cutting commented on AVRO-1332:
------------------------------------

With the latest patch, on Linux, one test fails:

{code}
1) Test Error : Avro.Test.SpecificTests.TestEnumResolution()
   System.IndexOutOfRangeException : Array index is out of range.
  at 
Avro.Generic.ResolvingDatumReader`1+<ResolveEnum>c__AnonStorey1[Avro.Test.EnumRecord].<>m__D
 (System.Object r, Decoder d) [0x00000] in <filename unknown>:0
{code}

Also, this patch makes some whitespace-only changes.  These are generally 
discouraged, as they make it harder for reviewers.

Lastly, there are some changes to public APIs that I'm not sure are 
back-compatible. (I don't know C#.)  Are these changes compatible or not?
                
> Improve C# DatumReader performance
> ----------------------------------
>
>                 Key: AVRO-1332
>                 URL: https://issues.apache.org/jira/browse/AVRO-1332
>             Project: Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.7.5
>            Reporter: David McIntosh
>            Priority: Minor
>              Labels: performance
>         Attachments: AVRO-1332-2.patch, AVRO-1332-3.patch, AVRO-1332.patch
>
>
> The current implementations of the C# datum readers perform resolution of the 
> reader and writer schema on every call to Read. In my tests this was causing 
> it to perform poorly when reading a large number of records (slower than 
> parsing the same data from delimited text files). It would be more efficient 
> if the reader only needed to resolve the schemas once.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to