[
https://issues.apache.org/jira/browse/AVRO-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765087#comment-13765087
]
David McIntosh commented on AVRO-1332:
--------------------------------------
Can you double check that you applied the "-3" version of the patch? That was
the test that was broken in the "-2" version but should be fixed in the "-3"
version.
I'll back out the whitespace changes.
The approach I'm thinking about taking to preserve compatibility is to leave
the older readers/writers unchanged and introduce the new ones as alternate
implementations. Anyone working through the DatumReader/Writer interfaces or
the data file apis would be able to switch over to them seamlessly or perhaps
they could even default to the newer ones. I'd need to do some work on the unit
test side to make sure the tests are running against both sets of
readers/writers. This has the downside of having to maintain two sets of code
that are very similar but if anyone is using the older internal implementations
of the readers/writers (the ones that don't implement the interfaces) we can't
remove them without a breaking change.
> Improve C# DatumReader performance
> ----------------------------------
>
> Key: AVRO-1332
> URL: https://issues.apache.org/jira/browse/AVRO-1332
> Project: Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.7.5
> Reporter: David McIntosh
> Priority: Minor
> Labels: performance
> Attachments: AVRO-1332-2.patch, AVRO-1332-3.patch, AVRO-1332.patch
>
>
> The current implementations of the C# datum readers perform resolution of the
> reader and writer schema on every call to Read. In my tests this was causing
> it to perform poorly when reading a large number of records (slower than
> parsing the same data from delimited text files). It would be more efficient
> if the reader only needed to resolve the schemas once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
