[
https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318926#comment-14318926
]
Sachin Goyal commented on AVRO-680:
-----------------------------------
Thanks [~rdblue], my responses on the same:
# Good catch.
Will change RuntimeException into AvroRuntimeException with a proper message.
# Are you proposing simpler name generation only for primitive types?
For user-defined classes like `Map<Foo, Bar>`, we cannot generate
`FooBarPair` because the Foo/Bar names may be present in multiple packages.
If you are proposing current naming strategy for complex types and simpler
naming strategy for primitives, then I am fine with that.
# Can you give me the code which did not give array schema for a non-string map?
# The very initial patch had normal array write logic with some special
handling to indicate non-string maps.
However we changed that to the current implementation based on some discussion
that happened above (Please see the comments around 21/Jul/14).
> Allow for non-string keys
> -------------------------
>
> Key: AVRO-680
> URL: https://issues.apache.org/jira/browse/AVRO-680
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.7.6, 1.7.7
> Reporter: Jeremy Hanna
> Attachments: AVRO-680.patch, AVRO-680.patch, PERF_8000_cycles.zip,
> isMap_Call_Hierarchy.png, non_string_map_keys.zip, non_string_map_keys2.zip,
> non_string_map_keys3.zip, non_string_map_keys4.patch,
> non_string_map_keys5.patch, non_string_map_keys6.patch,
> non_string_map_keys7.patch, non_string_map_perf.txt,
> non_string_map_perf2.txt, original_perf.txt
>
>
> Based on an email thread back in April, Doug Cutting proposed a possible
> solution for having non-string keys:
> Stu Hood wrote:
> > I can understand the reasoning behind AVRO-9, but now I need to look for an
> > alternative to a 'map' that will allow me to store an association of bytes
> > keys to values.
> A map of Foo has the same binary format as an array of records, each
> with a string field and a Foo field. So an application can use an array
> schema similar to this to represent map-like structures with, e.g.,
> non-string keys.
> Perhaps we could establish standard properties that indicate that a
> given array of records should be represented in a map-like way if
> possible? E.g.,:
> {"type": "array", "isMap": true, "items": {"type":"record", ...}}
> Doug
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
