[
https://issues.apache.org/jira/browse/AVRO-3171?focusedWorklogId=660923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660923
]
ASF GitHub Bot logged work on AVRO-3171:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/21 13:51
Start Date: 06/Oct/21 13:51
Worklog Time Spent: 10m
Work Description: RyanSkraba opened a new pull request #1351:
URL: https://github.com/apache/avro/pull/1351
The node.js tests were fixed for the "Active LTD" version 14 in AVRO-3171
but not yet for later versions. The Dockerfile build should target this
version until the version 16 fixes are done.
### Jira
- [X] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3171
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR does not need testing for this extremely good reason: Validated
manually building release candidates.
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 660923)
Time Spent: 0.5h (was: 20m)
> JavaScript: test failures for BlockEncoder#empty
> ------------------------------------------------
>
> Key: AVRO-3171
> URL: https://issues.apache.org/jira/browse/AVRO-3171
> Project: Apache Avro
> Issue Type: Bug
> Components: javascript
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Running `./build.sh test` in lang/js fails with:
>
> {code:java}
> 380 passing (3s)
> 1 failing 1) files
> BlockEncoder
> empty:
> Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure
> "done()" is called; if returning a Promise, ensure it resolves.
> (/home/martin/git/apache/avro/lang/js/test/test_files.js)
> at listOnTimeout (internal/timers.js:554:17)
> at processTimers (internal/timers.js:497:7)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
