[ https://issues.apache.org/jira/browse/AVRO-3171?focusedWorklogId=661158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-661158 ]
ASF GitHub Bot logged work on AVRO-3171: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Oct/21 20:03 Start Date: 06/Oct/21 20:03 Worklog Time Spent: 10m Work Description: martin-g commented on a change in pull request #1354: URL: https://github.com/apache/avro/pull/1354#discussion_r723635522 ########## File path: lang/js/lib/protocols.js ########## @@ -1099,6 +1099,8 @@ MessageDecoder.prototype._flush = function () { this.emit('error', new Error('trailing data')); } else if (this._empty) { this.emit('error', new Error('no message decoded')); + } else { + this.emit('finish'); Review comment: This fixes the issue with Node.js 16 but it is a mystery to me why `finish` event is not emitted automatically on the Transform stream after the reabable.end(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 661158) Time Spent: 1h (was: 50m) > JavaScript: test failures for BlockEncoder#empty > ------------------------------------------------ > > Key: AVRO-3171 > URL: https://issues.apache.org/jira/browse/AVRO-3171 > Project: Apache Avro > Issue Type: Bug > Components: javascript > Reporter: Martin Tzvetanov Grigorov > Assignee: Martin Tzvetanov Grigorov > Priority: Minor > Labels: pull-request-available > Fix For: 1.11.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Running `./build.sh test` in lang/js fails with: > > {code:java} > 380 passing (3s) > 1 failing 1) files > BlockEncoder > empty: > Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure > "done()" is called; if returning a Promise, ensure it resolves. > (/home/martin/git/apache/avro/lang/js/test/test_files.js) > at listOnTimeout (internal/timers.js:554:17) > at processTimers (internal/timers.js:497:7) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)