[ 
https://issues.apache.org/jira/browse/AVRO-3601?focusedWorklogId=800197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800197
 ]

ASF GitHub Bot logged work on AVRO-3601:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Aug/22 07:20
            Start Date: 12/Aug/22 07:20
    Worklog Time Spent: 10m 
      Work Description: martin-g commented on code in PR #1821:
URL: https://github.com/apache/avro/pull/1821#discussion_r944181406


##########
lang/c++/impl/CustomAttributes.cc:
##########
@@ -0,0 +1,51 @@
+
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "CustomAttributes.hh"
+#include <map>
+#include <memory>
+#include "Exception.hh"
+
+namespace avro {
+
+std::string CustomAttributes::getAttribute(const std::string &name) const {
+    std::map<std::string, std::string>::const_iterator iter =
+        attributes_.find(name);
+    if (iter == attributes_.end()) {
+      return NULL;

Review Comment:
   No, there is no such test.
   Suggestions how to rework this ? Maybe return Option(al) ?! I have to see 
which version of C++ supports this.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 800197)
    Time Spent: 2h  (was: 1h 50m)

> C++ API header contains breaking include
> ----------------------------------------
>
>                 Key: AVRO-3601
>                 URL: https://issues.apache.org/jira/browse/AVRO-3601
>             Project: Apache Avro
>          Issue Type: Bug
>            Reporter: Mike Ruffing
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to