[ https://issues.apache.org/jira/browse/AVRO-3601?focusedWorklogId=800234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800234 ]
ASF GitHub Bot logged work on AVRO-3601: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Aug/22 09:12 Start Date: 12/Aug/22 09:12 Worklog Time Spent: 10m Work Description: martin-g commented on code in PR #1821: URL: https://github.com/apache/avro/pull/1821#discussion_r944269272 ########## lang/c++/impl/Compiler.cc: ########## @@ -268,14 +268,14 @@ static const std::unordered_set<std::string>& getKnownFields() { return kKnownFields; } -static void getCustomAttributes(const Object& m, CustomFields &customAttributes) +static void getCustomAttributes(const Object& m, CustomAttributes &customAttributes) { // Don't add known fields on primitive type and fixed type into custom // fields. const std::unordered_set<std::string>& kKnownFields = getKnownFields(); for (const auto &entry : m) { if (kKnownFields.find(entry.first) == kKnownFields.end()) { - customAttributes.addField(entry.first, entry.second); + customAttributes.addAttribute(entry.first, entry.second.stringValue()); Review Comment: https://github.com/apache/avro/pull/1826/commits/074eef4272bf563a334e42a1027890f0c34dcccc Looks good ? Issue Time Tracking ------------------- Worklog Id: (was: 800234) Time Spent: 3h (was: 2h 50m) > C++ API header contains breaking include > ---------------------------------------- > > Key: AVRO-3601 > URL: https://issues.apache.org/jira/browse/AVRO-3601 > Project: Apache Avro > Issue Type: Bug > Reporter: Mike Ruffing > Assignee: Martin Tzvetanov Grigorov > Priority: Major > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Problem file/line: > https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24 > Steps to reproduce: > * Download AVRO version 1.11.1 > * Execute {{./build.sh install}} (from the {{lang/c++ directory}}) > * Navigate to the installed {{include}} directory > * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists > in the installed {{include}} directory > Relates to: https://issues.apache.org/jira/browse/AVRO-3547 -- This message was sent by Atlassian Jira (v8.20.10#820010)