Hi Chad, Please open a Draft PR with your changes! It will be easier to review and comment on it! Thank you!
On Fri, Feb 2, 2024 at 10:20 PM Chad Preisler <chad.preis...@gmail.com> wrote: > I created a fork and branch that removes JDK 8 from the build and makes 11 > default. The changes can be seen here: > > https://github.com/cpreisler/avro/tree/remove-jdk-8 > > Let me know what if anything you want me to do with this. > > > On Mon, Jan 29, 2024 at 4:19 AM Niels Basjes <ni...@basjes.nl> wrote: > > > Yes, Dropping the runtime support for Java 8 is enough of a reason to > bump > > to AVRO 2.0.0 for me. > > > > On Mon, Jan 8, 2024 at 6:09 PM Stephen Kittelson > > <steph...@qualtrics.com.invalid> wrote: > > > >> More and more libraries these days are dropping support for JDK 8 (at > >> least > >> Spring Boot 3, Jakarta EE 11, Mockito 5, among others), so I personally > >> think it would be fine to drop support for JDK 8 in 1.12.0, or maybe > even > >> bump the Avro release to 2.0.0 with the removal of JDK 8 support? > >> > >> On Mon, Jan 8, 2024 at 2:38 AM Martin Grigorov <mgrigo...@apache.org> > >> wrote: > >> > >> > Hi, > >> > > >> > I think this is a good idea! > >> > > >> > Some PRs (mostly by dependabot) are not merged because Avro needs to > be > >> JDK > >> > 8 compatible and the dependencies require a newer JDK... > >> > I am not sure whether Avro 1.12.0 still needs to be JDK 8 compatible > or > >> > not. > >> > > >> > Martin > >> > > >> > On Sat, Jan 6, 2024 at 5:55 PM Chad Preisler <chad.preis...@gmail.com > > > >> > wrote: > >> > > >> > > Hello, > >> > > > >> > > I'm wondering if there is any interest in making Apache Avro a > proper > >> > Java > >> > > module? The following changes are required. > >> > > > >> > > - Add or generate the module-info.java file. > >> > > - Change the POM file to build a multi-release jar. > >> > > - Replace xerial Snappy with Apache commons-compress Snappy (see > >> > additional > >> > > information below). > >> > > - Update dependencies (like slf4) to the current versions. > >> > > - Build with newer JDK. I'm using 21. > >> > > > >> > > Regarding the Snappy compressor, the next version of Apache > >> > > commons-compress (1.25.1) can be swapped in for Xerial with no > issues. > >> > All > >> > > of the existing unit tests will work without changes. Xerial is not > a > >> > > proper Java module at this time, and it uses JNI which could make it > >> > tricky > >> > > (especially if the goal is to use jlink). > >> > > > >> > > For me, the motivation here is to use Avro with modularized > >> > > applications and custom runtime images using jlink. > >> > > > >> > > I currently have this working locally, and I can contribute my > >> changes. > >> > > > >> > > Please let me know what you think. > >> > > > >> > > Thanks, > >> > > > >> > > Chad > >> > > > >> > > >> > > > > > > -- > > Best regards / Met vriendelijke groeten, > > > > Niels Basjes > > >
