Great! Thanks Sourabh. - Cham
On Wed, Mar 1, 2017 at 3:58 PM Robert Bradshaw <rober...@google.com.invalid> wrote: > Much needed! Added a couple of comments. > > On Wed, Mar 1, 2017 at 3:08 PM, Sourabh Bajaj < > sourabhba...@google.com.invalid> wrote: > > > Hi, > > > > BEAM-1441 <https://issues.apache.org/jira/browse/BEAM-1441> is a ticket > > for > > implementing the Beam File System in the Python SDK similar to the one > > introduced in BEAM-59 <https://issues.apache.org/jira/browse/BEAM-59>. I > > tried to take a pass on the implementation in #2136 > > <https://github.com/apache/beam/pull/2136> and followed the Java API as > > closely as possible. Please feel free to give your comments here or on > the > > pull request directly. > > > > Reference: Original design doc > > <https://docs.google.com/document/d/11TdPyZ9_zmjokhNWM3Id- > > XJsVG3qel2lhdKTknmZ_7M/edit#> > > > > > > Thanks > > Sourabh > > >