Thanks for the feedback Tibor. I think in the first iteration we can probably assume that the underlying filesystem is taking care of permission enforcement. Once we have a few sources using the FS API we can may be revisit this as we'll surely learn a few things from that. Thoughts ?
On Sun, Mar 19, 2017 at 12:16 AM Tibor Kiss <tk...@hortonworks.com> wrote: > Thanks for putting this together, Sourabh! > I made two comments in the document (error handling, with statement). > > Are there any plans to support permissions (mode bits or acls) in the FS > API? > I believe most (if not all) of the underlying filesystems support (some > sort of) permission enforcement. > > Thanks, > Tibor > > > On Mar 17, 2017, at 10:14 PM, Sourabh Bajaj > > <sourabhba...@google.com.INVALID> > wrote: > > > > Wanted to share the design proposal > > < > https://docs.google.com/document/d/10qD0RXmdI0240wPShaGDRm9Zt9a_ess-ABlvYx2LZFA/edit#heading=h.czvx1winvche > > > > for the Beam File System API in python. I have marked the places where it > > might be slightly different from the current Java implementation, mainly > > around error handling. As always feedback and comments are welcome. > > > > Thanks > > Sourabh > > > > On Wed, Mar 1, 2017 at 4:44 PM Chamikara Jayalath <chamik...@apache.org> > > wrote: > > > >> Great! Thanks Sourabh. > >> > >> - Cham > >> > >> On Wed, Mar 1, 2017 at 3:58 PM Robert Bradshaw > <rober...@google.com.invalid > >>> > >> wrote: > >> > >>> Much needed! Added a couple of comments. > >>> > >>> On Wed, Mar 1, 2017 at 3:08 PM, Sourabh Bajaj < > >>> sourabhba...@google.com.invalid> wrote: > >>> > >>>> Hi, > >>>> > >>>> BEAM-1441 <https://issues.apache.org/jira/browse/BEAM-1441> is a > >> ticket > >>>> for > >>>> implementing the Beam File System in the Python SDK similar to the one > >>>> introduced in BEAM-59 <https://issues.apache.org/jira/browse/BEAM-59 > >. > >> I > >>>> tried to take a pass on the implementation in #2136 > >>>> <https://github.com/apache/beam/pull/2136> and followed the Java API > >> as > >>>> closely as possible. Please feel free to give your comments here or on > >>> the > >>>> pull request directly. > >>>> > >>>> Reference: Original design doc > >>>> <https://docs.google.com/document/d/11TdPyZ9_zmjokhNWM3Id- > >>>> XJsVG3qel2lhdKTknmZ_7M/edit#> > >>>> > >>>> > >>>> Thanks > >>>> Sourabh > >>>> > >>> > >> > >
