szewi commented on a change in pull request #4169: [BEAM-3060] Added support
for multiple filesystems in TextIO
URL: https://github.com/apache/beam/pull/4169#discussion_r153293998
##########
File path: sdks/java/io/file-based-io-tests/pom.xml
##########
@@ -139,6 +139,24 @@
</plugins>
</build>
</profile>
+ <profile>
+ <!-- Include the google-cloud-platform activated by
-Dfilesystem=GCS
+ Support for protocol scheme gs:// - allow to read/write to google
storage -->
+ <id>google-cloud-storage</id>
+ <activation>
+ <property>
+ <name>filesystem</name>
+ <value>GCS</value>
Review comment:
When provided -Dfilesystem=gcs it won't activate this profile. We should
make decision whether uppercased or lowercased value of property is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
