szewi commented on a change in pull request #4169: [BEAM-3060] Added support
for multiple filesystems in TextIO
URL: https://github.com/apache/beam/pull/4169#discussion_r153296166
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/TextIOIT.java
##########
@@ -81,13 +81,38 @@ public static void setup() throws ParseException {
.as(IOTestPipelineOptions.class);
numberOfTextLines = options.getNumberOfRecords();
- filenamePrefix = appendTimestamp(options.getFilenamePrefix());
+ filenamePrefix = resolveProtocolAndPath(options);
}
private static String appendTimestamp(String filenamePrefix) {
return String.format("%s_%s", filenamePrefix, new Date().getTime());
}
+ private static String resolveProtocolAndPath(IOTestPipelineOptions options) {
Review comment:
Sure. However if in the future we will have kind of "validator" that will
validate test input parameters, then it would reassemble `--filenamePrefix` I
guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
