I got your point Aljoscha. Flink runner is the only module using this suffix.
Spark runner, Kafka IO, and others also have a scala dep but don't use the suffix. So, we have three options: 1. We leave as it is right now 2. We remove suffix from Flink runner 3. We add suffix to other modules (Spark runner, Kafka IO, ...) Thoughts ? I'm OK to stay on 1 for now. Regards JB On 02/01/2018 02:45 PM, Aljoscha Krettek wrote: > I think it's not wise to remove the Scala suffix. When using the Flink Runner > you have to make sure that the Scala version matches the Scala version of the > Flink Cluster. And I think comparing the suffix of your flink-runner > dependency and the suffix of your Flink dist is an easy way of doing that. > > >> On 31. Jan 2018, at 16:55, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: >> >> Hi Romain, >> >> AFAIR only Flink runner uses scala version in the artifactId. >> >> +1 for me. >> >> Regards >> JB >> >> On 01/31/2018 04:45 PM, Romain Manni-Bucau wrote: >>> Hi guys >>> >>> since beam supports a single version of runners why not dropping the scala >>> version from the artifactId? >>> >>> ATM upgrades are painful cause you upgrade beam version....+ runner >>> artifactIds. >>> >>> wdyt? >>> >>> Romain Manni-Bucau >>> @rmannibucau <https://twitter.com/rmannibucau> | Blog >>> <https://rmannibucau.metawerx.net/> | Old Blog >>> <http://rmannibucau.wordpress.com> | Github >>> <https://github.com/rmannibucau> | >>> LinkedIn <https://www.linkedin.com/in/rmannibucau> >> >> -- >> Jean-Baptiste Onofré >> jbono...@apache.org >> http://blog.nanthrax.net >> Talend - http://www.talend.com > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
