+1 (binding)
On Tue, Mar 20, 2018 at 10:46 AM Robert Bradshaw <rober...@google.com> wrote: > On Tue, Mar 20, 2018 at 4:08 AM Ismaël Mejía <ieme...@gmail.com> wrote: > >> +1 (binding) >> >> - Validated hashs >> - mvn clean verify -Prelease OK >> - Run nexmark on direct/flink/spark (it works save the regression >> already tracked on RC2). >> >> Thanks Robert for being managing the release. >> >> ps. One 'future' question after seeing the wheel artifacts (that seem >> to be python version / OS specific) introduced in this RC I was >> wondering how can we validate that those are correct for future >> releases (probably something to add to the validation guide or to >> automatize). >> > > Good question. We should automate this. If their generation is automated > (and runs tests) we can also have higher confidence in their correctness. > > On Tue, Mar 20, 2018 at 7:40 AM, Valentyn Tymofieiev >> <valen...@google.com> wrote: >> > I also tried to run python streaming mobile gaming examples >> > (hourly_team_score, leader_board) on direct runner with little success: >> > https://issues.apache.org/jira/browse/BEAM-3889. I think they escaped >> our >> > attention on previous release validations. I just tried them with 2.3.0 >> and >> > didn't have much luck either. Since I am not sure when these examples >> last >> > worked and warnings shows the examples are using deprecated constructs, >> I >> > suspect the issue is with examples, and we can address it separately >> from >> > 2.4.0 release. >> > >> > On Mon, Mar 19, 2018 at 7:21 PM, Valentyn Tymofieiev < >> valen...@google.com> >> > wrote: >> >> >> >> +1. >> >> Ran a Python Streaming wordcount pipeline on Direct and Dataflow >> runners >> >> and Batch mobile gaming examples on Dataflow runner. >> >> >> >> On Mon, Mar 19, 2018 at 6:02 PM, Alan Myrvold <amyrv...@google.com> >> wrote: >> >>> >> >>> +1 I ran the java quickstarts against 2.4.0 and they passed. >> >>> ./gradlew :release:runQuickstartsJava >> >>> -Prepourl= >> https://repository.apache.org/content/repositories/orgapachebeam-1031 >> >>> -Pver=2.4.0 >> >>> >> >>> >> >>> On Mon, Mar 19, 2018 at 5:41 PM Ahmet Altay <al...@google.com> wrote: >> >>>> >> >>>> I was able to run hourly_team_score. I was passing a wrong argument. >> No >> >>>> need for an alarm. :) >> >>>> >> >>>> On Mon, Mar 19, 2018 at 5:33 PM, Ahmet Altay <al...@google.com> >> wrote: >> >>>>> >> >>>>> +1 Thank you Robert. >> >>>>> >> >>>>> Verified python mobile gaming examples using the wheel files on >> direct >> >>>>> runner. Got user_score working but hourly_team_score failed with >> >>>>> (https://issues.apache.org/jira/browse/BEAM-3824). Since this is >> an example, >> >>>>> I think it is fine to continue with the release. I will work on >> fixing the >> >>>>> example post release. >> >>>>> >> >>>>> On Mon, Mar 19, 2018 at 2:46 PM, Konstantinos Katsiapis >> >>>>> <katsia...@google.com> wrote: >> >>>>>> >> >>>>>> +1, since Tf.Transform 0.6 depends on (and is blocked by) Beam 2.4 >> >>>>>> >> >>>>>> On Sat, Mar 17, 2018 at 2:19 AM, Robert Bradshaw < >> rober...@google.com> >> >>>>>> wrote: >> >>>>>>> >> >>>>>>> Hi everyone, >> >>>>>>> >> >>>>>>> Please review and vote on the release candidate #3 for the version >> >>>>>>> 2.4.0, >> >>>>>>> as follows: >> >>>>>>> [ ] +1, Approve the release >> >>>>>>> [ ] -1, Do not approve the release (please provide specific >> comments) >> >>>>>>> >> >>>>>>> The complete staging area is available for your review, which >> >>>>>>> includes: >> >>>>>>> * JIRA release notes [1], >> >>>>>>> * the official Apache source release to be deployed to >> >>>>>>> dist.apache.org [2], >> >>>>>>> which is signed with the key with fingerprint BDC9 89B0 1BD2 A463 >> >>>>>>> 6010 A1CA >> >>>>>>> 8F15 5E09 610D 69FB [3], >> >>>>>>> * all artifacts to be deployed to the Maven Central Repository >> [4], >> >>>>>>> * source code tag "v2.4.0-RC3" [5], >> >>>>>>> * website pull request listing the release and publishing the API >> >>>>>>> reference >> >>>>>>> manual [6]. >> >>>>>>> * Java artifacts were built with Maven 3.2.5 and OpenJDK >> 1.8.0_112. >> >>>>>>> * Python artifacts are deployed along with the source release to >> the >> >>>>>>> dist.apache.org [2]. >> >>>>>>> >> >>>>>>> The validation spreadsheet is available at >> >>>>>>> >> >>>>>>> >> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit?ts=5a1c7310#gid=1663314475 >> >>>>>>> >> >>>>>>> The vote will be open for at least 72 hours. It is adopted by >> >>>>>>> majority >> >>>>>>> approval, with at least 3 PMC affirmative votes. >> >>>>>>> >> >>>>>>> Thanks, >> >>>>>>> - Robert >> >>>>>>> >> >>>>>>> [1] >> >>>>>>> >> >>>>>>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342682&projectId=12319527 >> >>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.4.0/ >> >>>>>>> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS >> >>>>>>> [4] >> >>>>>>> >> https://repository.apache.org/content/repositories/orgapachebeam-1031/ >> >>>>>>> [5] https://github.com/apache/beam/tree/v2.4.0-RC3 >> >>>>>>> [6] https://github.com/apache/beam-site/pull/398 >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> -- >> >>>>>> Gus Katsiapis | Software Engineer | katsia...@google.com | >> >>>>>> 650-918-7487 >> >>>>> >> >>>>> >> >>>> >> >> >> > >> >
