Hi all, I'll humbly declare that after wrestling with he build to stop depending on the wrong findbugs_annotations, I feel somewhat lost. The issue is actually quite small:
- The JAR from the non-LGPL findbugs does not contain the SuppressFBWarnings annotation. This means that when building, ByteBuddy produces a few warnings (nothing critical). - The easiest way to avoid this failure is to call applyJavaNature(failOnWarning: false), but this would be bad, since we want to keep a high standard for tasks like ErrorProne and FindBugs itself. - So I find myself lost: How do we suppress trivial warnings coming from missing annotations, and honor warnings coming from other plugins? Any help / a PR from someone more capable would be appreciated. Best -P. On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía <ieme...@gmail.com> wrote: > Yes, ok I was not aware it was already being addressed, nice. > On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay <al...@google.com> wrote: > > > > Ismaël, > > > > I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing > the issue by changing the findbugs back to "com.github.stephenc.findbugs". > Is this what you are referring to? > > > > Ahmet > > > > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang <boyu...@google.com> > wrote: > >> > >> Hey JB, > >> > >> I added some instructions about how to create python wheels in this PR: > https://github.com/apache/beam-site/pull/467 . Hope it would be helpful. > >> > >> Boyuan > >> > > > -- Got feedback? go/pabloem-feedback
