Hi Tim, you're right. Thanks for pointing that out. There's just one problem that I'm running into now: The 3.0.1-1 version does not seem to be available in Maven Central[1]. Looking at the website, I am not quite sure if there's another repository where they do stage the newer versions?[2]
-P [1] https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations / [2] http://stephenc.github.io/findbugs-annotations/ On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <[email protected]> wrote: > Hi Pablo, > > I took only a quick look. > > "- The JAR from the non-LGPL findbugs does not contain the > SuppressFBWarnings annotation" > > Unless I misunderstand you it looks like SuppressFBWarnings was added in > Stephen's version in this commit [1] which was introduced in version > 2.0.3-1 - I've checked is in the 3.0.1-1 build [2] > I notice in your commits [1] you've been exploring version 3.0.0 already > though... what happens when you use 3.0.1-1? It sounds like the wrong > version is coming in rather than the annotation being missing. > > Thanks, > Tim > > [1] > https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java > [2] https://github.com/stephenc/findbugs-annotations/releases > [3] > https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab > > > > > > > > On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada <[email protected]> wrote: > >> Hi all, >> I'll humbly declare that after wrestling with he build to stop depending >> on the wrong findbugs_annotations, I feel somewhat lost. The issue is >> actually quite small: >> >> - The JAR from the non-LGPL findbugs does not contain the >> SuppressFBWarnings annotation. This means that when building, ByteBuddy >> produces a few warnings (nothing critical). >> - The easiest way to avoid this failure is to call >> applyJavaNature(failOnWarning: false), but this would be bad, since we want >> to keep a high standard for tasks like ErrorProne and FindBugs itself. >> - So I find myself lost: How do we suppress trivial warnings coming from >> missing annotations, and honor warnings coming from other plugins? >> >> Any help / a PR from someone more capable would be appreciated. >> Best >> -P. >> >> On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía <[email protected]> wrote: >> >>> Yes, ok I was not aware it was already being addressed, nice. >>> On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay <[email protected]> wrote: >>> > >>> > Ismaël, >>> > >>> > I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing >>> the issue by changing the findbugs back to "com.github.stephenc.findbugs". >>> Is this what you are referring to? >>> > >>> > Ahmet >>> > >>> > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang <[email protected]> >>> wrote: >>> >> >>> >> Hey JB, >>> >> >>> >> I added some instructions about how to create python wheels in this >>> PR: https://github.com/apache/beam-site/pull/467 . Hope it would be >>> helpful. >>> >> >>> >> Boyuan >>> >> >>> > >>> >> -- >> Got feedback? go/pabloem-feedback >> <https://goto.google.com/pabloem-feedback> >> > > -- Got feedback? go/pabloem-feedback
