Thanks Mik and Kenn for taking care of this, which should really be my job.
On Fri, Jun 22, 2018 at 1:27 AM Mikhail Gryzykhin <[email protected]> wrote: > Thank you for update on this. > > PR is up: > https://github.com/apache/beam/pull/5721 > > --Mikhail > > > On Thu, Jun 21, 2018 at 10:12 AM Kenneth Knowles <[email protected]> wrote: > >> The Gearpump runner has been on master for a long time and is part of our >> releases. I don't know when this issue showed up of if the Jenkins job >> never was switched back then, but we should definitely switch it to be >> analogous to all the other ValidatesRunner suites running on master. It is >> possible this will reveal some issues if the tests have really not been >> running for a long time. But it is a valid signal that we should have. >> >> Kenn >> >> On Thu, Jun 21, 2018 at 10:04 AM Mikhail Gryzykhin <[email protected]> >> wrote: >> >>> Hello everyone, >>> >>> I see that in Jenkins we have >>> a beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle job configured. >>> >>> Yesterday, I unified creation of post-commit jobs and this made all >>> post-commit tests run on schedule and enabled Gearpump tests job. >>> Unfortunately, that job is configured to run against unexisting branch >>> "gearpump-runner" and began failing. >>> >>> I wonder what is the history of Gearpump runner. If we are not working >>> on this runner, it would be good to disable and remove/rename this job to >>> reduce clutter in Jenkins. >>> >>> Otherwise any person looking at post-commit tests will be confused with >>> not running or disabled job. >>> >>> Currently, I'm going to revert my change to make that job only run on >>> comment on PullRequest as it was before. >>> >>> However I want your input is it ok removing this job completely or >>> renaming it? >>> >>> Regards, >>> --Mikhail >>> >>>
