Hi Udi, I see that the PR was merged - thanks! However it seems to have some unintended effects.
On my PR https://github.com/apache/beam/pull/5940 , I assigned a reviewer manually, but the moment I pushed a new commit, it auto-assigned a lot of other people to it, and I had to remove them. This seems like a big inconvenience to me, is there a way to disable this? Thanks. On Thu, Jul 12, 2018 at 2:53 PM Udi Meiri <eh...@google.com> wrote: > :/ That makes it a little less useful. > > On Thu, Jul 12, 2018 at 11:14 AM Tim Robertson <timrobertson...@gmail.com> > wrote: > >> Hi Udi >> >> I asked the GH helpdesk and they confirmed that only people with write >> access will actually be automatically chosen. >> >> It don't expect it should stop us using it, but we should be aware that >> there are non-committers also willing to review. >> >> Thanks, >> Tim >> >> On Thu, Jul 12, 2018 at 7:24 PM, Mikhail Gryzykhin <mig...@google.com> >> wrote: >> >>> Idea looks good in general. >>> >>> Did you look into ways to keep this file up-to-date? For example we can >>> run monthly job to see if owner was active during this period. >>> >>> --Mikhail >>> >>> Have feedback <http://go/migryz-feedback>? >>> >>> >>> On Thu, Jul 12, 2018 at 9:56 AM Udi Meiri <eh...@google.com> wrote: >>> >>>> Thanks all! >>>> I'll try to get the file merged today and see how it works out. >>>> Please surface any issues, such as with auto-assignment, here or in >>>> JIRA. >>>> >>>> On Thu, Jul 12, 2018 at 2:12 AM Etienne Chauchot <echauc...@apache.org> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> I added myself as a reviewer for some modules. >>>>> >>>>> Etienne >>>>> >>>>> Le lundi 09 juillet 2018 à 17:06 -0700, Udi Meiri a écrit : >>>>> >>>>> Hi everyone, >>>>> >>>>> I'm proposing to add auto-reviewer-assignment using Github's >>>>> CODEOWNERS mechanism. >>>>> Initial version is here: *https://github.com/apache/beam/pull/5909/files >>>>> <https://github.com/apache/beam/pull/5909/files>* >>>>> >>>>> I need help from the community in determining owners for each >>>>> component. >>>>> Feel free to directly edit the PR (if you have permission) or add a >>>>> comment. >>>>> >>>>> >>>>> Background >>>>> The idea is to: >>>>> 1. Document good review candidates for each component. >>>>> 2. Help choose reviewers using the auto-assignment mechanism. The >>>>> suggestion is in no way binding. >>>>> >>>>> >>>>> >>
