Thanks Udi! On Thu, Dec 5, 2019 at 2:07 PM Udi Meiri <eh...@google.com> wrote:
> The pytest tasks are there for me (or someone else) to verify that they > can replace the nose ones. > If you make changes to tox environments, please make changes to the > corresponding -pytest env as well. > > Regarding extras, go ahead in adding "interactive" to the extras option > (both py3x and py3x-pytest targets please). > > On Thu, Dec 5, 2019 at 1:55 PM Ning Kang <ni...@google.com> wrote: > >> Hi Udi, >> >> Are the temporary pytest tasks in use for pre-commit check or anything >> currently? >> I see there is still WIP for BEAM-3713 >> <https://issues.apache.org/jira/browse/BEAM-3713>. >> >> There is only one task "pythonPreCommitPytest" depending on the pytest >> tasks using the pytest environment configs. >> And it's invoked here: >> >> PrecommitJobBuilder builderPytest = new PrecommitJobBuilder( >> scope: this, >> nameBase: 'Python_pytest', >> gradleTask: ':pythonPreCommitPytest', >> commitTriggering: false, >> timeoutMins: 180, >> ) >> >> builderPytest.build {...} >> >> >> On Wed, Dec 4, 2019 at 5:51 PM Ning Kang <ni...@google.com> wrote: >> >>> Thanks for the heads up! I was wondering why the interactive tests are >>> skipped, lol. >>> So we are moving away from the deprecated pytest-runner (with the >>> changes in setup.py) but still sticking to pytest since it's replacing >>> nosetest. >>> >>> Can I add "interactive" as "extras" to testenv "py37-pytest" and >>> "py36-pytest" in tox.ini >>> <https://github.com/apache/beam/blob/master/sdks/python/tox.ini#L100> >>> then? >>> >>> @Ahmet Altay <al...@google.com> fyi >>> >>> On Wed, Dec 4, 2019 at 5:22 PM Pablo Estrada <pabl...@google.com> wrote: >>> >>>> +Ning Kang <ni...@google.com> +Sam Rohde <sro...@google.com> fyi >>>> >>>> On Wed, Nov 27, 2019 at 5:09 PM Udi Meiri <eh...@google.com> wrote: >>>> >>>>> As part of a move to stop using the deprecated (and racey) setup.py >>>>> keywords setup_requires and test_require, interactive runner dependencies >>>>> have been removed from tests in >>>>> https://github.com/apache/beam/pull/10227 >>>>> >>>>> If this breaks any tests, please let me know. >>>>> >>>>
