Nice! This will help at least temporarily. We can see if it grows too unwieldy. It is still unfriendly to newcomers.
Kenn On Tue, Jan 14, 2020 at 11:06 AM Pablo Estrada <pabl...@google.com> wrote: > Hi all, > ASF INFRA gave us a middle-ground sort of workaround for this by using > .asf.yaml files. Here's a change to implement it[1], and documentation for > the .asf.yaml file[2], as well as the relevant section for our case[3]. > > I'll check the docs in [2] well before pushing to merge, just to be sure > we're not breaking anything. > > [1] https://github.com/apache/beam/pull/10582 > [2] > https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories > > [3] > https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-JenkinsPRWhitelisting > > On Mon, Jan 13, 2020 at 3:29 PM Luke Cwik <lc...@google.com> wrote: > >> I'm for going back to the status quo where anyone's PR ran the tests >> automatically or to the suggestion where users marked as contributors had >> their tests run automatically (with the documentation update about how link >> your github/jira accounts). >> >> On Mon, Jan 13, 2020 at 2:45 AM Michał Walenia < >> michal.wale...@polidea.com> wrote: >> >>> Hi, >>> I wanted to decouple the conversation about solutions to the issue from >>> job execution requests. >>> We have 131 open PRs right now and 64 committers with job running >>> privileges. From what I counted, more than 80 of those PRs are not authored >>> by committers. >>> I think that having committers answer testing and retesting requests is >>> a temporary solution and a permanent one should be decided upon soon. While >>> it's an inconvenience for contributors familiar with the workings of the >>> project and the community, newcomers might be put off by the fact that the >>> tests don't run automatically on their pull requests (this is an industry >>> standard which IMO should be upheld also in Beam). The barrier of finding >>> one of committers who is active and willing to trigger their tests can make >>> the entry to the project more difficult. >>> >>> I believe that the solution proposed by Kenneth in the Jira thread >>> https://issues.apache.org/jira/browse/INFRA-19670 is viable. The >>> questions are: do we want to implement this idea and what needs to be done >>> to do it? >>> >>> Regards >>> Michał >>> >>> -- >>> >>> Michał Walenia >>> Polidea <https://www.polidea.com/> | Software Engineer >>> >>> M: +48 791 432 002 <+48791432002> >>> E: michal.wale...@polidea.com >>> >>> Unique Tech >>> Check out our projects! <https://www.polidea.com/our-work> >>> >>
