> Would someone be willing to review and merge https://github.com/apache/beam/pull/14878 which should fix this?
Done! Thanks for writing the fix. On Mon, May 24, 2021 at 8:22 PM Daniel Collins <dpcoll...@google.com> wrote: > Looks to me like this is flaky because the Watch class doesn't provide a > way to ensure a number of iterations have occurred. > > Would someone be willing to review and merge > https://github.com/apache/beam/pull/14878 which should fix this? > > On Mon, May 24, 2021 at 10:44 PM Reuven Lax <re...@google.com> wrote: > >> It appears to be flaky. After several reruns, the test finally succeeded. >> >> On Mon, May 24, 2021 at 7:21 PM Daniel Collins <dpcoll...@google.com> >> wrote: >> >>> Looking. This is a very surprising test to be failing, the underlying >>> class just isn't doing that much. >>> >>> On Mon, May 24, 2021 at 9:21 PM Reuven Lax <re...@google.com> wrote: >>> >>>> Hmmm... I'm seeing this fail during Java PreCommit. >>>> >>>> On Mon, May 24, 2021 at 6:19 PM Evan Galpin <evan.gal...@gmail.com> >>>> wrote: >>>> >>>>> It did, yes :-) >>>>> >>>>> On Mon, May 24, 2021 at 21:17 Reuven Lax <re...@google.com> wrote: >>>>> >>>>>> Did Java PreCommit pass on your PR? >>>>>> >>>>>> On Mon, May 24, 2021 at 5:42 PM Evan Galpin <evan.gal...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> I’m not certain that it’s related based on a quick scan of the test >>>>>>> output that you linked, but I do know that I recently made a change[1] >>>>>>> to >>>>>>> Reshuffe.AssignToShard which @Daniel Collins mentioned was used by >>>>>>> PubSub >>>>>>> Lite[2]. >>>>>>> >>>>>>> Given that the change is recent and the test is failing on remote >>>>>>> but not locally, I thought maybe the remote test env might be using the >>>>>>> AssignToShard change and your local code might not? (not certain if the >>>>>>> remote tests use exact SHA or rebase code on master first possibly?) >>>>>>> >>>>>>> [1] https://github.com/apache/beam/pull/14720 >>>>>>> >>>>>>> [2] >>>>>>> https://lists.apache.org/x/thread.html/r62b191e8318413739520b67dd3a4dfa788cbbc7b8d91ad9a80720dc6@%3Cdev.beam.apache.org%3E >>>>>>> >>>>>>> >>>>>>> On Mon, May 24, 2021 at 20:27 Reuven Lax <re...@google.com> wrote: >>>>>>> >>>>>>>> This test keeps failing on my PR. For example: >>>>>>>> >>>>>>>> >>>>>>>> https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/17841/testReport/junit/org.apache.beam.sdk.io.gcp.pubsublite/SubscriptionPartitionLoaderTest/addedResults/ >>>>>>>> >>>>>>>> I haven't changed anything related to this test, and it passes for >>>>>>>> me locally. Is anyone else seeing this test fail? >>>>>>>> >>>>>>>> Reuven >>>>>>>> >>>>>>>
