Thanks JB and Jesse. Would something like "MakeDistinct" or "AvoidDuplicate" sound better? I can do the collective changes of the name and the javadoc at one go.
Having it documented can be super helpful. On Mon, Oct 24, 2016 at 9:58 AM, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > It could make sense. However we should keep it informative. I mean that > distinct could appear confusing for some users compare to AvoidDuplicate or > whatever. > > Regards > JB > > > > On Oct 24, 2016, 18:46, at 18:46, Jesse Anderson <je...@smokinghand.com> > wrote: > >My original thought for this change was that Crunch uses the class name > >Distinct. SQL also uses the keyword distinct. > > > >Maybe the rule should be changed to adjectives or verbs depending on > >the > >context. > > > >Using a verb to describe this class really doesn't connote what the > >class > >does as succinctly as the adjective. > > > >On Mon, Oct 24, 2016 at 9:40 AM Neelesh Salian <nsal...@cloudera.com> > >wrote: > > > >> Hello, > >> > >> First of all, thank you to Daniel, Robert and Jesse for their review > >on > >> this: https://issues.apache.org/jira/browse/BEAM-239 > >> > >> A point that came up was using verbs explicitly for Transforms. > >> Here is the PR: https://github.com/apache/incubator-beam/pull/1164 > >> > >> Posting it to help understand if we have a consensus for it and if > >yes, we > >> could perhaps document it for future changes. > >> > >> Thank you. > >> > >> -- > >> Neelesh Srinivas Salian > >> Engineer > >> > -- Neelesh Srinivas Salian Customer Operations Engineer
