[
https://issues.apache.org/jira/browse/BIGTOP-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289617#comment-14289617
]
Mark Grover commented on BIGTOP-989:
------------------------------------
Thanks Mani! Overall this looks good, thanks for posting a patch, here are a
few comments:
* I don't think kafka package should depend on zookeeper-server. Depending on
zookeeper is ok but it's rare that a non-server package needs to depend on a
server package.
* In the init file, I noticed that there was a reference to PIDFI. The variable
name seems to have been truncated from PIDFILE, can you take a second look,
please?
* Any particular reason the %{files} section in spec file doesn't include all
of %{bin} instead of individually listing out each of the files in it?
* Copyright should say 2015 instead of 2014
Thanks!
> Add Apache Kafka to Apache Bigtop
> ----------------------------------
>
> Key: BIGTOP-989
> URL: https://issues.apache.org/jira/browse/BIGTOP-989
> Project: Bigtop
> Issue Type: New Feature
> Components: debian
> Affects Versions: 0.6.0
> Reporter: Diederik van Liere
> Labels: features
> Fix For: backlog
>
> Attachments: BIGTOP-989-1.patch, BIGTOP-989-2.patch,
> BIGTOP-989-3.patch, BIGTOP-989-4.patch, BIGTOP-989.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
