No problem, it makes sense, and it didn't really take too much work to split out SparkR support into a separate commit. I have updated the pull request now. There are now four commits:
* upgrade to Spark 1.5.1, including splitting out some jars to new packages: spark-datanucleus, spark-extras, spark-yarn-shuffle * Puppet module changes * purely cosmetic changes * add support for SparkR (both packaging and one small Puppet change together) ~ Jonathan On Mon, Oct 5, 2015 at 6:32 PM, RJ Nowling <rnowl...@gmail.com> wrote: > Thank you for your patience and efforts! > > On Tue, Oct 6, 2015 at 2:53 AM, Jonathan Kelly <jonathaka...@gmail.com> > wrote: > > > RJ, > > > > Yes, makes sense. And good point about it meaning more commits. :) Hehe. > > > > ~ Jonathan > > > > On Mon, Oct 5, 2015 at 4:34 PM, RJ Nowling <rnowl...@gmail.com> wrote: > > > > > Hi Jonathan, > > > > > > I actually want to remove R from the Spark 1.5.1 patch and add Spark R > + > > > the toll chain changes as a second patch / JIRA. And I'd like to see > the > > > puppet deployment changed as a third JIRA/PR. > > > > > > If you can do that, I can review the first two and get those in. > > > > > > I apologize for the extra work but you'll also get more commits this > way. > > > :) > > > > > > RJ > > > > > > > On Oct 5, 2015, at 6:11 PM, Jonathan Kelly <jonathaka...@gmail.com> > > > wrote: > > > > > > > > Ah, you guys reminded me that I'd completely forgotten to include in > my > > > > Spark 1.5.1 patch the changes I had made to add R to the toolchain, > but > > > it > > > > sounds like you don't actually want that added right now anyway? Of > > > course, > > > > Spark won't build without it though (after my patch, that is), > unless I > > > > were to make some other changes to the Spark build to make SparkR > > > optional. > > > > Is that something you want me to do, or should I just wait for the > work > > > > that Olaf has proposed? > > > > > > > > Thanks, > > > > Jonathan > > > > > > > >> On Mon, Oct 5, 2015 at 3:21 AM, Olaf Flebbe <o...@oflebbe.de> wrote: > > > >> > > > >> > > > >>> Am 05.10.2015 um 09:12 schrieb Konstantin Boudnik <c...@apache.org > >: > > > >>> > > > >>> On Sun, Oct 04, 2015 at 09:22PM, Olaf Flebbe wrote: > > > >>>> Hi, > > > >>>> > > > >>>> there are options to have clean room dependency installation for > > > debian > > > >> and > > > >>>> rpm systems: debian's pbuilder and fedora's mock. > > > >>>> > > > >>>> These would make the whole dependency installation by puppet > > obsolete. > > > >>>> Everything would be installed on demand only and thrown away > > > afterwards. > > > >>>> > > > >>>> If I have enough time I will look into integrating this into our > > > >> toolchain > > > >>>> (at least optionally) > > > >>> > > > >>> That'd be quite cool, thanks! I wonder where it leaves Susa? > > > >>> > > > >>> Cos > > > >> > > > >> ... gooogling ... > > > >> > > > >> opensuse does have a thing called "build", shares the same idea. > > > >> > > > >> Olaf > > > >> > > > > > >
