On Sun, Aug 11, 2013 at 8:31 PM, Olemis Lang <[email protected]> wrote:
> On 8/11/13, Ryan Ollos <[email protected]> wrote: > > On Thu, Aug 8, 2013 at 9:32 AM, Olemis Lang <[email protected]> wrote: > > > >> On 8/8/13, Ryan Ollos <[email protected]> wrote: > >> > On Tue, Jul 23, 2013 at 4:53 AM, Anze Staric <[email protected]> > >> wrote: > >> > > >> >> Why are there two templates for product admin > >> >> (bloodhound_multiproduct/multiproduct/templates/admin_products.html > >> >> and bloodhound_theme/bhtheme/templates/bh_admin_products.html)? Is > the > >> >> first one ever used? > >> > > >> > > >> > I'm not exactly sure, but I'd previously thought that > >> `admin_products.html` > >> > exists so that the MultiProduct plugin will work when the Bloodhound > >> Theme > >> > is disabled. > >> > > >> > >> right ... since the beginning Gary suggested that Bootstrap-specific > >> enhancements should be added by theme , and simple templates were > >> provided in multiproduct plugin . > >> > > > > Which reminds me, I think we should consider moving the Bootstrap content > > to `bloodhound_theme`, so I've created #633: > > https://issues.apache.org/bloodhound/ticket/633 > > > > Bootstrap css+js is used by both dashboard and theme . If it is > migrated onto theme how will it be made available for dashboard > layouts and widgets as well ? > The Boostrap CSS and JS are added by bloodhoud_theme.html, so only the paths would need to be changed, e.g. dashboard/css/bootstrap.css -> theme/css/bootstrap.css BloodhoundDashboard calls add_stylesheet a few times, and we'd have to change the path to the content. It seems logical for the Boostrap code to be part of the ThemePlugin since it is responsible for adding Boostrap to all of the pages (via `bloodhound_theme.html`). I agree with the aim that "Bootstrap-specific enhancements should be added by theme". If more work needs to be done for this to be realized in BloodhoundDashboard, then I think we should at least consider making those changes.
