On 8/11/13, Ryan Ollos <[email protected]> wrote: > On Sun, Aug 11, 2013 at 8:31 PM, Olemis Lang <[email protected]> wrote: > [...] >> > Which reminds me, I think we should consider moving the Bootstrap >> > content >> > to `bloodhound_theme`, so I've created #633: >> > https://issues.apache.org/bloodhound/ticket/633 >> > >> >> Bootstrap css+js is used by both dashboard and theme . If it is >> migrated onto theme how will it be made available for dashboard >> layouts and widgets as well ? >> > > The Boostrap CSS and JS are added by bloodhoud_theme.html, so only the > paths would need to be changed, e.g. dashboard/css/bootstrap.css -> > theme/css/bootstrap.css BloodhoundDashboard calls add_stylesheet a few > times, and we'd have to change the path to the content. >
my concern is that such approach will lead to cyclic package dependencies i.e. theme depends upon dashboard widgets to build the UI whereas dashboard depends upon theme for bootstrap styling . That's a problematic situation [citation needed]. I do not see the benefit of adding such complexity just to move bootstrap files to a different plugin (especially if they are working ok where they are now). The other alternative I see is to create a separate package for shared assets . > It seems logical for the Boostrap code to be part of the ThemePlugin since > it is responsible for adding Boostrap to all of the pages (via > `bloodhound_theme.html`). I agree with the aim that "Bootstrap-specific > enhancements should be added by theme". If more work needs to be done for > this to be realized in BloodhoundDashboard, then I think we should at least > consider making those changes. > Not all bootstrap styles have to be added by theme . Widgets are «self-contained» components so they have to take care of loading required assets , including bootstrap css+js , no matter on what context they are inserted . -- Regards, Olemis - @olemislc
