Yes, I am pretty happy with that though there may still be a few tweaks
to look at. I don't think that this is a huge reason to reject the patch
in its current form (potentially we can commit and continue to improve)
but we may want to consider what we want to do when users attempt to
include very long entries in free text fields, potentially testing the
limits of some browsers and webservers.
While we could resort to POSTing instead, I can see the reasoning behind
not doing that. Pragmatism would probably trump such reasoning though. I
think other solutions would either limit the field sizes or warn of
possible loss of data over some limit. Perhaps I have missed something
though.
Cheers,
Gary
On 11/12/13 11:42, Gary Martin wrote:
I haven't tested it quite yet but if my quick skim of the patch is
anything to go by, it is looking a lot closer to what I was hoping. To
be fair this is not quite what the wording of the ticket description
was suggesting but allowing for any fields that the form specifies at
the time of clicking the #qct-more button should be the right way to go.
And, yes, we do need to get the available choices for tickets updated
on change of product but that aspect doesn't need to be covered by
Antony's work. #618 may be a more appropriate ticket for that to come
under.
Anyway, I'll try out the patch now and see what actually happens!
Cheers,
Gary
On 11/12/13 10:54, Antony Semonella wrote:
Thanks for the tips Ryan,
I've created a patch so the "More fields" link functions with global
and product scope, hopefully we're
making a bit more progress :)
https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields_scope.diff
N.B. Functionality needs to be written to update product dependent
field values when a product
is changed in the QCT.
Cheers,
Antony
On 11 December 2013 09:49, Apache Bloodhound
<[email protected]> wrote:
#617: Switching from QCT to full create ticket page loses field values
------------------------+---------------------------
Reporter: mudri | Owner: antony
Type: defect | Status: needinfo(new)
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+---------------------------
Comment (by antony):
"More fields" link functioning with global and product scope, see:
[attachment:preserve_qct_fields_scope.diff]
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
