On Dec 16, 2013 12:27 PM, "Eric Ladner" <[email protected]> wrote: > > Ok.. so there's NOT a changeset template at the moment.. I assume the > template for a BH template is the original trac template (and it uses the > BH one if it exists, or defaults to the trac on if not)?
Yeah, the starting point for a bhtheme template is the Trac template. You can then add the bootstrap markup to get nice styling. The bhtheme template will only be used in place of the Trac template if we explicitly add it to the template map. > Or is there a mechanism to register a new template? The template map is in theme.py. I'll commit a changeset in a moment to demonstrate. > Sorry for the noob questions.. I'm trying to get used to how things work. > > I'll push the CSS changes up to bloodhound.css I'll take a look at your patch when it's ready, but i think we'll find that CSS changes aren't necessary once we have a bootstrap-based bloodhound template. > > On Mon, Dec 16, 2013 at 9:29 AM, Ryan Ollos <[email protected]> wrote: > > > On Dec 16, 2013 10:15 AM, "Eric Ladner" <[email protected]> wrote: > > > > > > I know the goal is to not change the upstream trac source, but simple > > > things like minor CSS changes, where should those be implemented to not > > > affect trac? > > > > > > Example: in 0.7, when viewing a source file via changeset, the > > Timestamp, > > > Author and Message labels are absolute positioned to the left side of the > > > window (very noticeable with a wide monitor). Setting it to "float: > > left" > > > gracefully fixes the problem, but the only way I can seem to get it to > > take > > > effect is by changing diff.css under the trac tree. > > > > > > Another lower level example.. When viewing change sets, sometimes the > > > source path name is extremely long and goes off the screen to the right > > > (the header "Changeset # in {product} for {SVN path}". So I figured I'd > > > hack in the jQuery TextFill plugin to reduce only the source name to a > > > maximum of 1170 pixels (width of current template content area). This > > > requires modifying trac/trac/versioncontrol/templates/changeset.html, > > > though, which is bad. Plus it hard codes some constants into the source > > > like the font height in pixels, the width of the page, etc. > > > > > > Is there a better way for modifying templates, html, css, etc than going > > > back to the trac source? > > > -- > > > Eric Ladner > > > > Yeah, fixes for the issues you mention should be applied to the bloodhound > > theme templates, which replace the Trac templates. In the case of the > > changeset view, a bloodhound template needs to be created, which is why > > it's unsightly at the moment. > > > > The bloodhound theme templates can be found in > > bloodhound_theme/bhtheme/templates. > > > > > > -- > Eric Ladner
