On Mon, Dec 16, 2013 at 2:21 PM, Ryan Ollos <[email protected]> wrote:
> On Mon, Dec 16, 2013 at 9:38 AM, Ryan Ollos <[email protected]>wrote: > >> >> On Dec 16, 2013 12:35 PM, "Eric Ladner" <[email protected]> wrote: >> > >> > On Mon, Dec 16, 2013 at 9:20 AM, Joachim Dreimann < >> > [email protected]> wrote: >> > >> > > On 16 December 2013 15:14, Eric Ladner <[email protected]> wrote: >> > > >> > >> > >> > > CSS should generally go into the bloodhound.css file. We're not using >> any >> > > Trac styles at this point, everything comes from that one file. >> > > jQuery plugins could also be added here and via the theme templates: >> > > >> > > >> https://issues.apache.org/bloodhound/browser/trunk/bloodhound_theme/bhtheme/templates >> > > >> > > >> > The changeset page includes "diff.css" and "code.css" in addition to >> > "bloodhound.css". And rightfully so, probably. That's a lot of extra >> CSS >> > to carry around just for styling this very specific content. >> > >> > The incorrect CSS is in the diff.css file. Keep the changes there or >> move >> > them to bloodhound.css? >> >> Either way is fine, just so we can get an idea of the changes you have >> in mind. We can iterate from there. >> > After [1551371] and [1551372] there is a bloodhound theme template for the > changeset page. It could use a lot of work on the styling, so that would be > a good task to pick up if you are so inclined. > > I think we could propose the following changes to diff.css, to be > committed to Trac: > > diff --git a/trac/trac/htdocs/css/diff.css b/trac/trac/htdocs/css/diff.css > index bc081cc..5e2ec32 100644 > --- a/trac/trac/htdocs/css/diff.css > +++ b/trac/trac/htdocs/css/diff.css > @@ -2,12 +2,16 @@ > #prefs fieldset { margin: 1em .5em .5em; padding: .5em 1em 0 } > > /* Diff/change overview */ > -#overview { line-height: 130%; margin-top: 1em; padding: .5em } > +#overview { > + line-height: 130%; > + margin-top: 1em; > + margin-left: 0; > + padding: .5em 0.5em 0.5em 0 > +} > #overview dt.property { > font-weight: bold; > padding-right: .25em; > position: absolute; /* relies on #content { position: relative } */ > - left: 0; > text-align: right; > width: 7.75em; > } > > Using absolute positioning for the element doesn't seem like very good > practice, so I think the changes would be positive for Trac. > > http://svn.apache.org/viewvc?view=revision&revision=r1551371 > http://svn.apache.org/viewvc?view=revision&revision=r1551372 > > > Another possible way to fix this would be to add the `position: relative` rule to the `#content` div. The `float: left` change looks useful as well, since we could drop the `position: absolute` rule. I opened a ticket in Trac to discuss the proposed upstream changes: http://trac.edgewall.org/ticket/11403.
