On 1/14/14, Ryan Ollos <[email protected]> wrote: > On Tue, Jan 14, 2014 at 5:42 PM, Saint Germain <[email protected]> wrote: > >> On Tue, 14 Jan 2014 16:14:06 +0100, Andrej Golcov <[email protected]> >> wrote : >> >> > I would suggest to make Bloodhound using Whoosh 2.5 (and removing >> > aforementioned workarounds) with search index rebuild when upgrading >> > from setup that uses indexes created with Whoosh 2.4. >> > >> >> Hello, >> >> I have created the ticket #741 to manage this point: >> https://issues.apache.org/bloodhound/ticket/741 >> >> I added a tentative patch to remove the workaround and remove/modify >> the tests accordingly. >> >> I have no experience on Bloodhound upgrade, so I haven't touched >> anything on this part. >> I also intend to manually test the search features of Bloodhound in the >> next days to check if anything is broken by this Whoosh upgrade (but >> having read the 2.5 changelog, it seems that there are no big changes). >> >> Best regards, >> > > Should we add Whoosh (and it's version) as a requirement in > `requirements.txt` and `requirements-dev.txt`, since BloodhoundSearch is > specified in that file? For other packages such as Trac we've included the > dependencies in the pip requirements file. >
I guess so , cmiiw . I really do not understand why this was not done before so maybe there is a reason for not including it ? -- Regards, Olemis - @olemislc
