[
https://issues.apache.org/jira/browse/BOOKKEEPER-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679268#comment-14679268
]
Hadoop QA commented on BOOKKEEPER-862:
--------------------------------------
Testing JIRA BOOKKEEPER-862
Patch
[ose_stats-rebase.patch|https://issues.apache.org/jira/secure/attachment/12749480/ose_stats-rebase.patch]
downloaded at Sun Aug 9 18:10:57 UTC 2015
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
. Tests run: 947
. Tests failed: 0
. Tests errors: 1
. The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/950/
> Add tracing and stats to OrderedSafeExecutor for debugging slow tasks
> ---------------------------------------------------------------------
>
> Key: BOOKKEEPER-862
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-862
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Leigh Stewart
> Assignee: Leigh Stewart
> Priority: Minor
> Fix For: 4.4.0
>
> Attachments: ose_stats-rebase.patch, ose_stats.patch
>
>
> Porting a change form the Twitter branch to improve stats and logging in
> OrderedSafeExecutor
> These changes have been helpful for us in debugging latency issues in
> Bookkeeper server/client
> Summary of changes is
> * add a config option for op stats
> * add stats for task execution time, task pending time
> * add a config option for logging a warning when an op takes longer than x
> micros
> * add toString implementations for submitted tasks so make it easier to track
> down slow ops
> * start using Builder for OrderedSafeExecutor
> * add a very simple test to make sure that the slow op logging path is
> exercised
> Most of this came from Sijie originally, with some changes from me
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
