[
https://issues.apache.org/jira/browse/BOOKKEEPER-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733897#comment-14733897
]
Sijie Guo commented on BOOKKEEPER-862:
--------------------------------------
re 1. => derepcated it
re 2. => using newBuilder everywhere in the code base
re 3. => we don't enforce this. if the application failed to override toString,
it would still give the class name, which is good enough for investigation.
new patch is attached.
> Add tracing and stats to OrderedSafeExecutor for debugging slow tasks
> ---------------------------------------------------------------------
>
> Key: BOOKKEEPER-862
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-862
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Leigh Stewart
> Assignee: Leigh Stewart
> Priority: Minor
> Fix For: 4.4.0
>
> Attachments: BOOKKEEPER-862.patch, BOOKKEEPER-862.patch,
> ose_stats-rebase.patch, ose_stats.patch
>
>
> Porting a change form the Twitter branch to improve stats and logging in
> OrderedSafeExecutor
> These changes have been helpful for us in debugging latency issues in
> Bookkeeper server/client
> Summary of changes is
> * add a config option for op stats
> * add stats for task execution time, task pending time
> * add a config option for logging a warning when an op takes longer than x
> micros
> * add toString implementations for submitted tasks so make it easier to track
> down slow ops
> * start using Builder for OrderedSafeExecutor
> * add a very simple test to make sure that the slow op logging path is
> exercised
> Most of this came from Sijie originally, with some changes from me
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
