[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189925#comment-15189925
 ] 

ASF GitHub Bot commented on BOOKKEEPER-594:
-------------------------------------------

GitHub user merlimat opened a pull request:

    https://github.com/apache/bookkeeper/pull/26

    BOOKKEEPER-594: AutoRecovery shutting down on SyncDisconnected

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merlimat/bookkeeper bk-594

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 26aa34b45fe045d1ba54e59ea375f85b9a9b1c20
Author: Matteo Merli <[email protected]>
Date:   2013-10-25T23:42:41Z

    BOOKKEEPER-594: AutoRecovery shutting down on SyncDisconnected

----


> AutoRecovery shutting down on SyncDisconnected
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-594
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-594
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-auto-recovery
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.4.0
>
>         Attachments: BOOKKEEPER-594.diff
>
>
> Currently the AutoRecovery daemon will shut down on SyncDisconnected. This is 
> the wrong behaviour. It should wait until it gets a expired signal before 
> shutting down. If autoRecoveryDaemonEnabled=true, then the autorecovery 
> deamon is running in the same process as the bookie, the bookie death watcher 
> will take down the bookie at this point also, but as the bookie hasn't 
> shutdown, exit code will be 0, which is confusing to any monitoring app.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to