[ https://issues.apache.org/jira/browse/BOOKKEEPER-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196703#comment-15196703 ]
ASF GitHub Bot commented on BOOKKEEPER-594: ------------------------------------------- Github user sijie commented on the pull request: https://github.com/apache/bookkeeper/pull/26#issuecomment-197140462 the change looks good to me. +1 > AutoRecovery shutting down on SyncDisconnected > ---------------------------------------------- > > Key: BOOKKEEPER-594 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-594 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery > Reporter: Ivan Kelly > Assignee: Matteo Merli > Priority: Critical > Fix For: 4.4.0 > > Attachments: BOOKKEEPER-594.diff > > > Currently the AutoRecovery daemon will shut down on SyncDisconnected. This is > the wrong behaviour. It should wait until it gets a expired signal before > shutting down. If autoRecoveryDaemonEnabled=true, then the autorecovery > deamon is running in the same process as the bookie, the bookie death watcher > will take down the bookie at this point also, but as the bookie hasn't > shutdown, exit code will be 0, which is confusing to any monitoring app. -- This message was sent by Atlassian JIRA (v6.3.4#6332)