I think forceGarabageCollection should be set in a final block. Can't remember why it wasn't in current master branch.
- Sijie On Tue, Feb 7, 2017 at 7:01 PM, Charan Reddy G <[email protected]> wrote: > Hi, > > I'm trying to understand the reason behind "continue;" statement in line > 352 of GarbageCollectorThread.java (https://github.com/apache/ > bookkeeper/blob/master/bookkeeper-server/src/main/ > java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java). It is > understandable that if we have done majorcompaction then minor compaction > is not required and it can be skipped, but aren't we missing " > forceGarbageCollection.set(false);" in line 362? Or is it supposed to be > like that? > > Basically I'm trying to findout when enableForceGC() is called, is it > supposed to trigger and do force GC/Compaction just once or untill it gets > disabled by calling disableForceGC()? > > Thanks, > Charan >
