👍 On Thu, Jul 13, 2017 at 5:34 AM, Venkateswara Rao Jujjuri <[email protected] > wrote:
> Awesome. !! > > On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli <[email protected]> > wrote: > > > The ticket has been closed. > > The protection is on > > > > -- Enrico > > > > 2017-07-07 11:22 GMT+02:00 Enrico Olivelli <[email protected]>: > > > > > > > > > > > 2017-07-07 1:51 GMT+02:00 Sijie Guo <[email protected]>: > > > > > >> +1 for disable force push to master > > >> > > > > > > > > > this is the issue: > > > https://issues.apache.org/jira/browse/INFRA-14535 > > > > > > I will send updates > > > > > > - Enrico > > > > > > > > >> > > >> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <[email protected]> > > >> wrote: > > >> > > >> > Other thoughts? > > >> > If there is no objection I would like to enable the force push > block. > > >> Next > > >> > week > > >> > > > >> > Enrico > > >> > > > >> > Il mar 4 lug 2017, 10:28 Enrico Olivelli <[email protected]> ha > > >> scritto: > > >> > > > >> > > 2017-07-04 5:51 GMT+02:00 Jia Zhai <[email protected]>: > > >> > > > Agree to have them protected. > > >> > > > Currently, seems these branches are not protected, at least > master > > >> > branch > > >> > > > is not. The merge button is still available even "Jenkins: Maven > > >> clean > > >> > > > install — Build finished." in some of PRs > > >> > > > <https://github.com/apache/bookkeeper/pulls> > > >> > > > We may first need to make the test stable. > > >> > > > > >> > > I think that is it enough to only protect against "force push", > > which > > >> > > makes impossible for anyone to 'rewrite' the "public history" of > the > > >> > > project > > >> > > Other checks are performed by QA test and by the committer who > takes > > >> > > responsibility for pushing the patch in the repo > > >> > > > > >> > > > > >> > > -- Enrico > > >> > > > > >> > > > > >> > > > > > >> > > > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli < > > >> [email protected]> > > >> > > wrote: > > >> > > > > > >> > > >> Hi, > > >> > > >> I don't know current configuration but I would like to ensure > > that > > >> our > > >> > > >> release branches, that is master and branch-xx are 'protected'. > > >> > > >> I mean at least that 'force push' must be forbidden to > everyone. > > >> > > >> > > >> > > >> In github it is simple to enable such protection, see > > >> > > >> https://help.github.com/articles/about-protected-branches/ > > >> > > >> > > >> > > >> I don't want to try btyy performing a force push. Maybe we can > > ask > > >> > infra > > >> > > >> about current configuration > > >> > > >> > > >> > > >> Thoughts? > > >> > > >> > > >> > > >> Enrico > > >> > > >> -- > > >> > > >> > > >> > > >> > > >> > > >> -- Enrico Olivelli > > >> > > >> > > >> > > > > >> > -- > > >> > > > >> > > > >> > -- Enrico Olivelli > > >> > > > >> > > > > > > > > > > > > -- > Jvrao > --- > First they ignore you, then they laugh at you, then they fight you, then > you win. - Mahatma Gandhi >
