sijie commented on a change in pull request #276: Issue-271
LedgerHandle#readEntries leaks ByteBufs
URL: https://github.com/apache/bookkeeper/pull/276#discussion_r129106853
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
##########
@@ -114,6 +116,10 @@
protected final static String ENABLE_BOOKIE_FAILURE_TRACKING =
"enableBookieFailureTracking";
protected final static String BOOKIE_FAILURE_HISTORY_EXPIRATION_MS =
"bookieFailureHistoryExpirationMSec";
+ // Netty
+ protected final static String NETTY_USE_POOLED_BUFFERS =
"nettyUsePooledBuffers";
+ protected final static boolean DEFAULT_NETTY_USE_POOLED_BUFFERS = true;
Review comment:
it is not a common practice to have the default value here. I'd prefer stick
to current practice. If we are going to change the practice, let's change them
all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
