sijie commented on a change in pull request #276: Issue-271
LedgerHandle#readEntries leaks ByteBufs
URL: https://github.com/apache/bookkeeper/pull/276#discussion_r129106589
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
##########
@@ -114,6 +116,10 @@
protected final static String ENABLE_BOOKIE_FAILURE_TRACKING =
"enableBookieFailureTracking";
protected final static String BOOKIE_FAILURE_HISTORY_EXPIRATION_MS =
"bookieFailureHistoryExpirationMSec";
+ // Netty
Review comment:
can you move this parameter to section ' // NIO Parameters '?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
