sijie commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-317760092 @yzang : I think the ideal override sequence of write/readonly status would be: 1. if a bookie is started with '--readonly' option, it will be forced readonly (ignoring the bookie status persisted in the disks and ignoring the real disk usage) 2. if a bookie is started without '--readonly' option, it will first respect the status persisted in the disks (because that is the status set for operation purpose). 3. if a bookie is started without '--readonly' option and there is not status persisted in the disks, that it will transition based on the read disk usage. 3) is already there regarding this change, 1) is achieved by this change, 2) is not ideal without this approach yet, we can make the case one the http endpoint is merged we can enable this there. I don't think you need another status field in this file. In the BookieStatus, you can distinguish 2) and 3) easily, 2) is the status persisted while 3) is the in-memory status. the final status is if 2) is readonly, the final status will be readonly regarding what status is 3), if 2) is writable, the final status will be the status of 3). Does that sound good? @yzang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
