sijie commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-318145467 @yzang sorry for late response. I was suggesting the status in BookieStatus is comprised of two parts : one is persisted status read from status file (let's call it 'persisted_status') and the other one is in-memory status that determined by disk usage (let's call it 'in_memory_status'). In non-force-readonly mode, the final status is determined by these two, if persisted_status is readonly, there is not transition will happen from readonly to writable. it is similar idea as what your proposed, but you don't have to persist another state. you just need to add another in-memory field in the bookie status class, and expose a method 'canTransitionToWritable'. so when disk listener detects disks are freed, it will check bookie status to see if it can transition to writable or not and decide the action. Does this make sense to you? @yzang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
