Github user bostko commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/319#discussion_r77530894
  
    --- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
 ---
    @@ -72,9 +74,17 @@
          */
         private int[] inboundPorts;
     
    +    private IpProtocol ipProtocol;
    +    private RangeSet<Integer> portRanges;
    --- End diff --
    
    I think to hold on this syntax for now and revert to your way.
    `org.jclouds.net.domain.IpPermission` has much more fields than just 
protocol and ports.
    The most accurate syntax is to use json representation of `IpPermission` 
but I'd like to keep it now, until someone else asks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to