Github user duncangrant commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/319#discussion_r78344937
  
    --- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
 ---
    @@ -74,6 +74,9 @@
     
         private RangeSet<Integer> tcpPortRanges;
         private RangeSet<Integer> udpPortRanges;
    +    private Boolean openIcmp;
    --- End diff --
    
    Looks like this fails on Azure - because Azure SGs don't support ICMP - 
probably should add a comment documenting what will happen in this case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to