Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/737#discussion_r124025405
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
@@ -601,14 +602,34 @@ private void collectCatalogItems(String sourceYaml,
Map<?,?> itemMetadata, List<
// if symname not set, infer from: id, then name, then item id,
then item name
if (Strings.isBlank(symbolicName)) {
--- End diff --
The changes in this block and the one below on versions are really pushing
the line number count of this method, would be nice to split them out into
another method; could it even be a method of `RegisteredTypeNaming`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
