Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/737#discussion_r124508303
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
 ---
    @@ -601,14 +602,34 @@ private void collectCatalogItems(String sourceYaml, 
Map<?,?> itemMetadata, List<
             // if symname not set, infer from: id, then name, then item id, 
then item name
             if (Strings.isBlank(symbolicName)) {
    --- End diff --
    
    want to completely gut this class as soon as #363 YOML is available, and 
remove much of this once 0.12.0 is out -- refactoring i think would make that 
harder as well as of course not being worth the effort if we're gutting it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to