Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149653548
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
@@ -253,4 +253,12 @@ public Response setConfig(
@ApiParam(value = "Whether to include subtasks recursively
across different entities (default false)", required = false)
@QueryParam("recurse") @DefaultValue("false") Boolean recurse);
+ @GET
+ @ApiOperation(value = "Returns an icon for the adjunct, if defined")
+ @Path("/{adjunct}/icon")
+ public Response getIcon(
+ @ApiParam(value = "Application ID or name", required = true)
@PathParam("application") String applicationId,
+ @ApiParam(value = "Entity ID or name", required = true)
@PathParam("entity") String entityId,
+ @ApiParam(value = "Adjunct ID or name", required = true)
@PathParam("adjunct") String adjunctToken);
+
--- End diff --
Yeah, I probably mixed up the name of REST endpoints with the multiple
methods of getting an icon. There are too many of them, it's really confusing
and hard to follow our REST API!
This looks fine to me.
---
