Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149655312
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
@@ -253,4 +253,12 @@ public Response setConfig(
@ApiParam(value = "Whether to include subtasks recursively
across different entities (default false)", required = false)
@QueryParam("recurse") @DefaultValue("false") Boolean recurse);
+ @GET
+ @ApiOperation(value = "Returns an icon for the adjunct, if defined")
+ @Path("/{adjunct}/icon")
+ public Response getIcon(
+ @ApiParam(value = "Application ID or name", required = true)
@PathParam("application") String applicationId,
+ @ApiParam(value = "Entity ID or name", required = true)
@PathParam("entity") String entityId,
+ @ApiParam(value = "Adjunct ID or name", required = true)
@PathParam("adjunct") String adjunctToken);
+
--- End diff --
Thx.
We should introduce `/v1/catalog/type/XXX/V/icon` for consistency with
`/v1/applications/XXX/icon` and `/v1/applications/XXX/entities/XXX/icon` and
`/v1/applications/XXX/entities/XXX/adjuncts/XXX/icon` and deprecate
/v1/catalog/icon/XXX/V`. But I think our multiple methods are sensible, you
can get an icon for instances, and for a type.
removing deprecated items like `CatalogEntitySummary` and others in favour
of `TypeSummary` should make it simpler
think on any other confusing things and let me know
---
