ahgittin commented on a change in pull request #1144:
URL: https://github.com/apache/brooklyn-server/pull/1144#discussion_r570166243



##########
File path: 
launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynLauncherRebindCatalogOsgiTest.java
##########
@@ -254,8 +254,8 @@ public void testRebindWithSystemBundleInCatalog() throws 
Exception {
             // Launch brooklyn, where persisted state now includes the initial 
catalog's bundle
             startT2(newLauncherForTests(initialBomFile.getAbsolutePath()));
             
-            // Should not have replaced the original "system bundle"
-            assertOnlyBundle(reusedFramework, bundleName, pseudoSystemBundle);
+            // FIXME Should we have replaced the original "system bundle" ???
+            assertBundleExists(reusedFramework, bundleName, 
pseudoSystemBundle);

Review comment:
       feels wrong




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to